search

duemunk / Async

Syntactic sugar in Swift for asynchronous dispatches in Grand Central Dispatch
MIT License
4.59k stars 316 forks source link

SPM Compatibility #140

Closed colemcampbell closed 5 years ago

colemcampbell commented 5 years ago

Is Swift Package Manager compatibility in the works? There's a Package.swift file in the repository but it doesn't seem to have ever been completed.

colemcampbell commented 5 years ago

Thanks for merging my branch! It currently works to pull from the master branch but it doesn't work with version rules currently because there isn't a tag that includes the updates to the package file.

duemunk commented 5 years ago

I've given you collaborator access. Feel free to update the version to a new one. Probably warrants a bump to 2.1.0.

duemunk commented 5 years ago

The readme could also benefit from adding SPM as an install method, probably the primarily suggested one.

colemcampbell commented 5 years ago

Do you want me to make a pull request with the necessary changes so that you can merge it and create a new tag, or would you like me to create the new tag as well?

duemunk commented 5 years ago

If you can all of it (including the tag) from your end I'll highly appreciate it.

colemcampbell commented 5 years ago

I updated the README and bumped the version number. I tested adding the package to a local project of mine and everything seems to be working!

duemunk commented 5 years ago

Great!

Fixed in #143.