Closed mowens closed 9 years ago
Thank you @mowens! This definitely looks interesting. Being quite busy, I hope to look at this over the holidays.
As for the unit test, you have to run them on an iOS device :)
Ah makes sense for the unit tests :)
it also might be worth refactoring the repo a bit. Instead of having the AsyncExample project, we could make new targets under the Async project (basically move the example code to the Async project). This way there is 1 uniform xcode project that builds the framework and sample projects.
@mowens I'm working on using CocoaPods for integrating Async
in Xcode. Do you think there is still a need for target to build a framework "manually"?
Or maybe add the support with https://github.com/Carthage/Carthage?
Cocoa pods will support swift (and thus dynamic frameworks) with 0.36 which there is a lot of activity on the cocoa pods github.
Carthage looks interesting. You will still need a separate target for carthage as it uses xcodebuild and this will require a schema to build.
I don't see why we could leverage both pods (when supported) and Carthage to give users the option. IMHO the best integration route would be to:
I think it would be a great idea to add support for Carthage
Adding Carthage support requires the async Xcode project to build a framework (this PR) as carthage is a wrapper on git and xcodebuild
Additionally CocoaPods has release swift beta support with 0.36.0.beta.1 and the current asyc pod spec works like a charm :)
Adding Carthage support requires the async Xcode project to build a framework (this PR) as carthage is a wrapper on git and xcodebuild
You already did this as part of the Pull Request. The only thing left to do here is to set the scheme in the xcode project as shared (checking the checkbox in the screenshot below)
I no I'm late to the game, but is this necessary anymore now that CocoaPods supports Swift? Please just reopen if necessary.
I haven't looked at the Carthage part.
@mowens @ksmandersen
Adding a dynamic framework target for better linking into swift projects.
Now that iOS8 supports dynamic frameworks, this is the ideal way to link in Swift projects. This is not yet supported by Cocoapods, however a PR for Swift frameworks exists.
The following adds:
To dynamic link against the new framework, follow the instructions here, but reference to Async.framework instead