search

duesee / abnf

A nom-based ABNF parser.
Apache License 2.0
17 stars 3 forks source link

Use nom 7.0.0-alpha1 and abnf-core 0.5.0 to avoid issues with dependencies. #18

Closed damirka closed 3 years ago

damirka commented 3 years ago

Hi there!

Follow up on PR to https://github.com/duesee/abnf-core/pull/3. Reasons for the bump are described in the abnf-core PR. Should be merged (if merged) only after abnf-core is updated and published to crates.io because of dependency on bumped version.

Tested on this branch with cargo git imports: https://github.com/damirka/abnf/tree/bump-nom-crate

duesee commented 3 years ago

Hey again :-) Sorry, I am a confused now... The PR title says "0.7.0-alpha1", the commit message says "0.6.5", but the change is to use nom "6.2.1"?

I thought we want to use nom 7.0.0-alpha1?

duesee commented 3 years ago

Could you please clarify what you want to archive and cleanup the commits? Maybe it would be easier to start with the abnf-core crate. Than we can come back here.

damirka commented 3 years ago

Done. Used force to rewrite commit message.

duesee commented 3 years ago

Also minor nit: Could you increase the version to 0.12.0 (due to the same reasons as in abnf-core) and use the commit message "Use nom 7.0.0-alpha1 and abnf-core 0.5.0 to avoid issues with dependencies"? Thank you!

I will merge this as soon as abnf-core 0.5.0 is published on crates.io.

damirka commented 3 years ago

@duesee done!

duesee commented 3 years ago

https://crates.io/crates/abnf/0.12.0 Hope that helps!