search

duesee / abnf

A nom-based ABNF parser.
Apache License 2.0
17 stars 3 forks source link

Implement RFC 7405. #21

Closed timothee-haudebourg closed 2 years ago

timothee-haudebourg commented 2 years ago

Hi, this PR is to implement case sensitive string introduced by RFC 7405.

duesee commented 2 years ago

Hey @timothee-haudebourg, this looks all very good. Thanks! I will try to properly review this PR in the following few days. Don't mind the failing license check in CI for now.

timothee-haudebourg commented 2 years ago

@duesee Thanks! Yes we have a use case for it there spruceid/treeldr/pull/35, did you figure out the CI problem? :smile:

duesee commented 2 years ago

Oh, thanks for the reminder! :-) https://github.com/duesee/abnf/pull/22 should fix the failing CI. Could you address the remaining two comments? This will be good to go then 👍🏻

timothee-haudebourg commented 2 years ago

@duesee sorry for the delay. Did you have time to see the changes?

duesee commented 2 years ago

No worries. Thanks again for the PR and for taking care of the requested changes! This should be good to go (when CI is happy) :+1:

duesee commented 2 years ago

I'll update the version and make a new release to crates.io :-)

duesee commented 2 years ago

Here we go https://crates.io/crates/abnf 🎉