duesee / imap-codec

Rock-solid and complete codec for IMAP
Apache License 2.0
37 stars 14 forks source link

fix: Remove `is_text_char_restricted`. #300

Closed duesee closed 1 year ago

duesee commented 1 year ago

Note: We need to resolve the Code ambiguity differently. Closes #299.

~This will lead to false-positives during fuzzing. However, usability trumps "correctness" here and we can revisit this after we confirmed that everything else works with Gmail.~ Fixed Arbitrary implementation for now.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5456069513


Changes Missing Coverage Covered Lines Changed/Added Lines %
imap-types/src/arbitrary.rs 29 30 96.67%
<!-- Total: 51 52 98.08% -->
Files with Coverage Reduction New Missed Lines %
imap-codec/src/response.rs 1 98.9%
imap-types/src/extensions/quota.rs 1 90.7%
imap-types/src/body.rs 2 39.47%
imap-types/src/flag.rs 2 62.5%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 5445090950: -0.05%
Covered Lines: 9092
Relevant Lines: 9751

💛 - Coveralls
duesee commented 1 year ago
Enter IMAP4REV1 response (or "exit"): * OK [HIGHESTMODSEQ 13637]
Status(
    Ok {
        tag: None,
        code: None,
        text: Text(
            "[HIGHESTMODSEQ 13637]",
        ),
    },
)

Okay, IMAP ambiguity + non-standard response in Gmail is... something. Use cut as soon as we are parsing a Code?