search

duesee / imap-codec

Rock-solid and complete codec for IMAP
Apache License 2.0
38 stars 14 forks source link

docs: Delete outdated note about constant-time comparisons in `Secret` #461

Closed jakoschiko closed 5 months ago

jakoschiko commented 7 months ago

https://github.com/duesee/imap-codec/blob/eb4d6d188e56b7cb89fda833e364297a20dbb04d/imap-types/src/secret.rs#L19-L21

  1. I don't understand the comment. Can you explain it to me/rephrase it?
  2. Is #[allow(clippy::derived_hash_with_manual_eq)] still necessary? Currently PartialEq and Eq are derived. Same for the Eq related tests.
duesee commented 7 months ago

Neither the comment (nor #[allow) allow make sense anymore.