fix: Resolve conflicting macro definition

duesee / imap-codec

Rock-solid and complete codec for IMAP

Apache License 2.0

35 stars 13 forks source link

fix: Resolve conflicting macro definition #503

Closed HenningHolmDE closed 2 weeks ago

HenningHolmDE commented 2 weeks ago

Previously, there were two macros named impl_try_from in scope in mailbox.rs (from import and local definition). While the build correctly resolved both macros, rust-analyzer did not and complained about using the imported macro. Renaming the local macro resolves this ambiguity and makes rust-analyzer happy.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9522064667

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.923%

Totals
Change from base Build 9437105437:	0.0%
Covered Lines:	9959
Relevant Lines:	11075

💛 - Coveralls

HenningHolmDE commented 2 weeks ago

Huch... I would have guessed this doesn't compile...

Yeah, would have thought as well. Learning something new every day. 🧑‍🎓

Thanks for the fix!

You're welcome!