duesee / imap-codec

Rock-solid and complete codec for IMAP
Apache License 2.0
35 stars 13 forks source link

Create project for python bindings #513

Closed HenningHolmDE closed 1 week ago

HenningHolmDE commented 1 week ago

This is part of #359.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9588789663

Details


Totals Coverage Status
Change from base Build 9569785020: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9600487009

Details


Totals Coverage Status
Change from base Build 9569785020: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9600919857

Details


Totals Coverage Status
Change from base Build 9569785020: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9619234997

Details


Totals Coverage Status
Change from base Build 9616749874: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9619377376

Details


Totals Coverage Status
Change from base Build 9616749874: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
HenningHolmDE commented 1 week ago

@duesee This PR contains the infrastructure changes for the Python bindings to be implemented. I'm happy to discuss any suggestions on doing things differently.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9620356209

Details


Totals Coverage Status
Change from base Build 9616749874: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
HenningHolmDE commented 1 week ago

Thanks! Looks very good to me. I left a few questions. I cannot test right now but will the bindings job work after a cargo clean? Do we expect some job order?

I just tested cargo clean followed by just bindings on my machine and it worked fine. Otherwise, I currently don't see why it would not work.

What do you mean by "job order"?

Suggesstion for some later time: Use black and maybe even mypy in CI? What do you think? :-)

Very good point! And don't forget about Ruff. I will check how easy it is to add them to the recipe and will either add them directly or create a corresponding issue.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9633473188

Details


Totals Coverage Status
Change from base Build 9616749874: 0.0%
Covered Lines: 10190
Relevant Lines: 10995

💛 - Coveralls
HenningHolmDE commented 1 week ago

Adding checks for Black, Ruff and mypy was fairly easy, thanks for the suggestion. :+1:

I now updated the code to address all topics discussed earlier.