Closed HenningHolmDE closed 1 week ago
Totals | |
---|---|
Change from base Build 9569785020: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
Totals | |
---|---|
Change from base Build 9569785020: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
Totals | |
---|---|
Change from base Build 9569785020: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
Totals | |
---|---|
Change from base Build 9616749874: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
Totals | |
---|---|
Change from base Build 9616749874: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
@duesee This PR contains the infrastructure changes for the Python bindings to be implemented. I'm happy to discuss any suggestions on doing things differently.
Totals | |
---|---|
Change from base Build 9616749874: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
Thanks! Looks very good to me. I left a few questions. I cannot test right now but will the bindings job work after a
cargo clean
? Do we expect some job order?
I just tested cargo clean
followed by just bindings
on my machine and it worked fine. Otherwise, I currently don't see why it would not work.
What do you mean by "job order"?
Suggesstion for some later time: Use
black
and maybe evenmypy
in CI? What do you think? :-)
Very good point! And don't forget about Ruff. I will check how easy it is to add them to the recipe and will either add them directly or create a corresponding issue.
Totals | |
---|---|
Change from base Build 9616749874: | 0.0% |
Covered Lines: | 10190 |
Relevant Lines: | 10995 |
Adding checks for Black, Ruff and mypy was fairly easy, thanks for the suggestion. :+1:
I now updated the code to address all topics discussed earlier.
maturin
template project forPyO3
in which the Python bindings for imap-codec will be implemented.sum_to_string
of the template project that is available from the compiled Rust code.bindings
just recipe running build and test of the Python bindings can be triggered.This is part of #359.