Typed support for SIZE parameter (RFC 1870)

duesee / smtp-codec

Parsing and construction of SMTP messages

Apache License 2.0

6 stars 2 forks source link

Typed support for SIZE parameter (RFC 1870) #4

Closed zeenix closed 2 years ago

zeenix commented 2 years ago

This PR main adds typed support for SIZE parameter but also:

makes Parameter type an enum so future type support for other parameters can be more easily added. ~~Note that such addtions would still be an API-breaks though since the enum is exhaustive (I'm happy to change that as well if desired).~~ Note that the enum is non-exhaustive so that future variant addtions would not cause API breaks.
Fixes a bunch of clippy warnings.

duesee commented 2 years ago

Don't mind the failing CI. This will be fixed in https://github.com/duesee/smtp-codec/pull/5.

zeenix commented 2 years ago

@duesee I also added an additional commit now to declare the existing open-ended enums as non-exhaustive. Let me know if you disagree and I'll remove that commit.

zeenix commented 2 years ago

All changes are good :-) Thanks!

Awesome. Anything left before it can be merged?

duesee commented 2 years ago

🎉