search

duetds / date-picker

Duet Date Picker is an open source version of Duet Design System’s accessible date picker. Try live example at https://duetds.github.io/date-picker/
https://www.duetds.com
MIT License
1.73k stars 68 forks source link

Selected element (date) is not properly identified #129

Open Gabrielaparada opened 6 months ago

Gabrielaparada commented 6 months ago

The dates have an attribute of 'aria-pressed' which updates to true/false as they are selected/unselected. However, this is not the correct attribute to communicate the selected/unselected date, aria-pressed should only be used for toggle buttons which is not the case in this scenario.

Expected behavior aria-pressed should be replaced with 'aria-selected'

Screenshot 2024-05-08 at 1 26 43 PM
WickyNilliams commented 6 months ago

aria-selected is not valid on tables. Only on role=grid. We actually started out with that, but grid has its own set of problems.

After discussion with Adrian Roselli, we settled on the current approach. See https://github.com/duetds/date-picker/issues/26

Do you have any further info on aria-pressed being incorrect?

In any case, this repo is for all intents dead. I no longer have commit access, so any changes are unlikely. I have created a spiritual successor of sorts, [Cally] (https://github.com/WickyNilliams/cally). I'd be happy to continue discussion there if you like, and see what can be done