search

duetosymmetry / qnm

Python package for computing Kerr quasinormal mode frequencies, separation constants, and spherical-spheroidal mixing coefficients
https://qnm.readthedocs.io
MIT License
39 stars 19 forks source link

Suggest tqdm for download_data #11

Closed IanHawke closed 5 years ago

IanHawke commented 5 years ago

On first running it's unclear how long the qnm.download_data() will take. Could use tqdm (https://tqdm.github.io/) as a progress bar to make this clearer.

duetosymmetry commented 5 years ago

Here's a general question... is it reasonable to add tqdm as a requirement, though it's not really necessary to use the package? Or am I supposed to be using try/except at runtime to see if the user has tqdm, and fallback to no status output if they don't already have it?

IanHawke commented 5 years ago

That's a tricky one. I think of tqdm as a "standard" module like numpy and so would have no problem with it as a requirement, but I'm not sure how it's generally viewed. Also, given the standard way that it's used as a decorator, I don't think try/except is practical.

duetosymmetry commented 5 years ago

Merged into master.