dufernst / LegionCore-7.3.5

World of Warcraft - Legion (7.3.5 26972) source, based on leaked source from uwow.biz.
GNU General Public License v2.0
228 stars 228 forks source link

LFG / Scenario Bonus targets #201

Open slash-design opened 2 months ago

slash-design commented 2 months ago

The bonus objectives are not scored in the LFG dungeons. Don't think it's a DB issue, but a core issue. Suspect it's a .size issue in the scenario handler as the bonus objectives are not displayed correctly in the progress panel. These bonus objectives should be directly below the normal objectives. (see YouTube, or TC) In active quests, the bonus objectives are displayed at the end of the progress panel. This is wrong.

To the test....

Activate any quest tracking and then join via LFG in Gnomeregan....

Bonus is not counted and is displayed incorrectly in the progress panel

slash-design commented 2 months ago

This is the current situation... wrong display and it does not evaluate bonus targets

grafik

and this is what it should look like: (Source Youtube... it works with TrinityCore)

grafik

Bonus targets directly below the main targets...

slash-design commented 2 months ago

Update:

It was not due to the handler. I have rewritten the handler and the packets to TC-Like.

No change....

Does anybody have any ideas??

slash-design commented 2 months ago

Update:

The bonus objective Harlan in the Scarlet Halls, works

boss_armsmaster_harlan()

I haven't figured out why only this one works. I still don't know why the arrangement between main and bonus objectives is wrong :-(

slash-design commented 1 month ago

Update:

I have found out something else. If you have the final boss down in Gnomeregan, for example, then the bonus objectives count. On the progress panel the scoring happens for a short time and then the counter resets to 0/1. But only after the final boss is down.

Somewhere the logic is wrong.

d3athbl0w commented 1 month ago

Update:

I have found out something else. If you have the final boss down in Gnomeregan, for example, then the bonus objectives count. On the progress panel the scoring happens for a short time and then the counter resets to 0/1. But only after the final boss is down.

Somewhere the logic is wrong.

@slash-design can you contact me in discord d3athbl0w#9153 i want to ask something about how to compile this source in Debian 11

slash-design commented 1 month ago

Does no one have any ideas?

Etoyspeh commented 2 weeks ago

@slash-design fix Hi. Try adding these rows to the database, quest_objective table:

INSERT INTO legion_world.quest_objectives (ID, QuestID, Type, StorageIndex, ObjectID, Amount, Flags, Flags2, TaskStep, Description, VerifiedBuild) VALUES (1100000, 35602, 14, 0, 36988, 1, 0, 0, 0, 'Defeat Grubbis.', 26972), (1100001, 35602, 14, 2, 36990, 1, 0, 0, 0, 'Defeat Viscous Fallout.', 26972), (1100002, 35602, 14, 1, 36992, 1, 0, 0, 0, 'Defeat Electrocutioner 6000.', 26972), (1100003, 35602, 14, 0, 36994, 1, 0, 0, 0, 'Defeat Crowd Pummeler 9-60..', 26972);