search

duff2013 / UartEvent

Event Based Hardware Serial for Teensy 3.1
18 stars 11 forks source link

Major bug fix in end functions and smaller fixes in other functions #3

Closed matteovigni closed 6 years ago

matteovigni commented 6 years ago

Fixed secondary constructor for uart2 and uart3 (they were using the wrong divisor macros)

Added disabling of status IRQ on the end functions of the three uarts. If the irqs were left on the uart was not able to resume transmitting after after calling the end function and the begin function again.

Removed useless delays on the end functions.

Added return instructions that were missing in the write functions of uart2 and uart3

duff2013 commented 6 years ago

Thanks for the pull, looks good though I see you have made changes since your first pull, is it good to go now? I'm not able to test the pull at this time but I hope you can follow-up if others have issues.

matteovigni commented 6 years ago

Yes, I am sorry. The other changes are actually about the transmit circular buffer. I needed to send packets of 512 bytes and according to your comments I would have had to define a buffer of 1024 bytes for that, so I modified the logic behind the buffer so that it can actually send its full length worth of bytes.Unfortunately I haven't had the chance to test it with packets of different lengths, but I think it should be fine. If you want me to amend the last commit I can do it. On Apr 24, 2018 1:46 PM, duff2013 notifications@github.com wrote:Thanks for the pull, looks good though I see you have made changes since your first pull, is it good to go now? I'm not able to test the pull at this time but I hope you can follow-up if others have issues.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.