Missing `PassengerTitle` enum values

duffelhq / duffel-api-javascript

JavaScript client library for the Duffel API

https://duffel.com/docs

MIT License

36 stars 12 forks source link

Missing `PassengerTitle` enum values #886

Closed Tom-Carpendale closed 9 months ago

Tom-Carpendale commented 9 months ago

The docs specify 5 possible values for PassengerTitle, but the typescript types represent 3 of them in upper and lowercase, and miss the other 2:

https://github.com/duffelhq/duffel-api-javascript/blob/c308b4f761d1fccae03d964fffcabc7efd0ecc36/src/types/shared.ts#L67-L70

andrejak commented 9 months ago

Hi @Tom-Carpendale , this should be fixed now after this PR: https://github.com/duffelhq/duffel-api-javascript/pull/887 If you see any issues with it please let us know. Feel free to also submit PRs in the future if it's a simple fix :)