duffelhq / duffel-api-javascript

JavaScript client library for the Duffel API
https://duffel.com/docs
MIT License
36 stars 12 forks source link

Duffel flights with booked seats type not matching `Seat` metadata type #945

Open Tom-Carpendale opened 1 month ago

Tom-Carpendale commented 1 month ago

When creating an order, you can supply Services, such as baggage or seats. The order will then contain a services field, which is an array of OrderServices. These have a metadata field, which is typed like so metadata?: OrderServiceBaggageMetadata | Seat;. This Seat type can be found here: https://github.com/duffelhq/duffel-api-javascript/blob/61ef419d1e632f9a3c749b6f968299a433aa57a3/src/booking/Orders/OrdersTypes.ts#L23-L39

However, flights booked that use the Duffel carrier have null for the seat name, e.g.

{
  "segmendIds":["seg_0000Al1UTIYbFWGUecqV5E"],
  "metadata":{
    "disclosures":[],
    "designator":"29B",
    "name":null
  }
}

I'm not sure if the name should therefore be nullable, or if the Duffel flight orders should have a name provided for the seat services.

Many thanks!