On the dashboard we're seeing weird behaviour where the "View details" modal for NGS slices is buggy - it is laggy to click and close, the screen goes black, etc.
I don't see any of that in stories. My current speculative theory is that this could be happening because the tables on the dashboard are much larger than in the examples (hundreds vs a couple), and we were creating one modal per row. This refactors so we only create one modal per table.
Even if this doesn't fix the problem I still think it's a nice refactor. I would test it locally but it's quite hard with setting up a local dashboard with all the NGS feature flags to then use the local instance of duffel components. So once I've published a (canary) release I'll test that on dashboard staging.
On the dashboard we're seeing weird behaviour where the "View details" modal for NGS slices is buggy - it is laggy to click and close, the screen goes black, etc.
I don't see any of that in stories. My current speculative theory is that this could be happening because the tables on the dashboard are much larger than in the examples (hundreds vs a couple), and we were creating one modal per row. This refactors so we only create one modal per table.
Even if this doesn't fix the problem I still think it's a nice refactor. I would test it locally but it's quite hard with setting up a local dashboard with all the NGS feature flags to then use the local instance of duffel components. So once I've published a (canary) release I'll test that on dashboard staging.