duffelhq / duffel-components

A component library to help you build your travel product using the Duffel API
7 stars 3 forks source link

Make NGS table header sticky #274

Closed andrejak closed 5 months ago

andrejak commented 5 months ago

This is the first part of https://duffel.atlassian.net/browse/UXP-3437?atlOrigin=eyJpIjoiNmMyYTMyZjMwNTY1NDBjZjk1ZTY0MWVkYWZkMzk4NjciLCJwIjoiamlyYS1zbGFjay1pbnQifQ. It will require more than just a bump on the dashboard, started working on that here: https://github.com/duffelhq/dashboard/pull/4919

Some notes: Currently the NGS table is structured as an html table. These have some funny limitations with sticky positioning, e.g. you have to put it on th elements rather than thead or tr.

More importantly, having any parent with overflow set can break stickiness. In this case we have a few on the dashboard - on the page, its content, and around the NGS table (we had scrolling issues before). I’ve tried unsetting them but unsurprisingly this results in a bit of a mess, so it'll need a bit more thinking/work.