duffelhq / duffel-components

A component library to help you build your travel product using the Duffel API
7 stars 3 forks source link

Why are reusable components contain Duffe's Sentry integration? #302

Open ifeltsweet opened 3 months ago

ifeltsweet commented 3 months ago

We use Sentry to monitor errors in our application, however Duffel components also include Sentry which integrates with Duffel's Sentry account. This creates a bunch of different issues for us, including Sentry version incompatibilities.

I imagine a reusable library like this should not hardcode Duffel's Sentry integration for other apps to use. If it does it should make this integration optional and create a separate Sentry instance for itself - https://docs.sentry.io/platforms/javascript/best-practices/multiple-sentry-instances/