dufferzafar / Userscripts

A collection of scripts that make spending time on the web easy.
GNU General Public License v3.0
63 stars 27 forks source link

Bad release date from iTunes? #22

Open jesus2099 opened 5 years ago

jesus2099 commented 5 years ago

This iTunes page says released 2010-07-27 but if you import it, it will take 2010-07-26…?

augustjanse commented 5 years ago

Isn't this just iTunes having multiple date values?

jesus2099 commented 5 years ago

I see in https://itunes.apple.com/lookup?id=379320560&entity=song&limit=200&country=au that each track has a release date.

https://github.com/dufferzafar/Userscripts/blob/3691200ea1bef03f4699df6307c6a2d706ff06bd/MB-Import-From-iTunes.user.js#L43-L47

I think current code (above) takes first found track release date.

The imported album release date should be the latest track release date, not the earliest date nor the first track date. It seems to be how iTunes website works, for its own album page, BTW.

augustjanse commented 5 years ago

That makes sense. Nice dig!

jesus2099 commented 5 years ago

I did just a quick look, it is possible that there is, even better, a global release date in that stuff.

jesus2099 commented 5 years ago

Actually there is a final release date, the guitar in this result and it is what the user script uses. But in this case, some tracks are more recent and the iTunes web page does take the most recent track date and so should the user script do, even if it is strange.