duffey / spicetify-playlist-labels

Add playlist labels to Spotify tracklists
26 stars 3 forks source link

Playlist Labels stopped showing up #25

Open ianrispin opened 3 months ago

ianrispin commented 3 months ago

Spotify version 1.2.34.783.g923721d9 Spicetify version 2.36.4 MacOS 14.2.1

The arrangement of song data repositions to make space for playlist labels (as it always has for me), but the labels are not displaying. Here is a video of the behavior: https://github.com/duffey/spicetify-playlist-labels/assets/50210259/ad7d805d-c64e-45c8-ae64-a307d9db7489

An error appeared in the console that seemed to be connected to the issue, but I can't seem to recreate the error in the console (it appeared once and then never again). Here is a screenshot of the error: image

CharlieHoldcroft commented 3 months ago

Same started happening to me as well

cariosa commented 3 months ago

stopped working for me as well, I tried installing previous release but it doesn't install correctly (the logo doesn't show up in menubar) does the update has something to do with it?

duffey commented 3 months ago

Sorry guys! Yeah, I updated the extension to cache a bunch of playlist data, but there was a bug which made the cache invalid causing it to never load data again. I just pushed a fix. Please let me know if it works!

ianrispin commented 3 months ago

Still not showing up for me. I quit and re-opened spotify, but I'm still having the same issue

duffey commented 3 months ago

Hm, well I fixed a bug that occurred when you have over 50 playlists. I thought that was the cause. It seems to be working for me. Can you let me know again if their are any console errors? Also, can you show me what your local storage looks like for the values used by this extension?

image

WaddlesPlays commented 3 months ago

My labels stopped working recently as well, here's what I could uncover from DevTools:

Firstly, and this may be a separate issue, I noticed this error in the console whenever the extension is run:

image

Clicking on it took me to this snippet:

image

Seeing that c seemed to be a collection of liked songs, I figured this error may have been related to my lack of liked songs. To test, I liked a song and reloaded Spotify, which resolved the error and threw this error instead:

image

which leaves my local storage missing a few values when compared to your screenshot:

image

And, of course, the labels don't populate (although the divs for them are there)

Here's my spicetify version info in case that proves useful: Spotify for macOS (Apple Silicon) 1.2.35.663.gb699649e Spicetify v2.36.4 Theme: Sleek / CatppuccinMocha Extensions: oldCoverClick.js, shuffle+.js, fullScreenWrapper.js, volume-profiles.js, QueueTime.js, playlist-icons.js, volumePercentage.js, LuckyLP.js, power-bar.js, cat-jam.js, spicetify-playlist-labels.js Custom apps: marketplace, lyrics-plus, new-releases xpui_2024-04-05_1712324573103_b699649 cef_122.1.13+gde5b724+chromium-122.0.6261.130 Runtime: Chrome All of my extensions are from marketplace, and my MacOS version is 14.4.1

ianrispin commented 3 months ago

These are the values for me

image
duffey commented 3 months ago

@WaddlesPlays It seems that liking a song avoided one bug and then you experienced a different bug where you have so many playlists that it can't fit them all in local storage. I didn't think of this, so I will see if caching is still possible or what I should do.

SirSragus commented 3 months ago

Perhaps that was part of my original issue as well, I have a lot of playlists.

duffey commented 3 months ago

Considering it's possible to have so much playlist data it won't fit in local storage, I decided to revert the attempts at caching with local storage. I will explore using IndexedDB. Unfortunately startup will continue to be slow for people with many playlists until I figure out a better caching solution.

WaddlesPlays commented 3 months ago

It seems that liking a song avoided one bug and then you experienced a different bug where you have so many playlists that it can't fit them all in local storage. I didn't think of this, so I will see if caching is still possible or what I should do.

I see! Should I file a separate issue for the liked songs bug?

duffey commented 2 months ago

@WaddlesPlays Is it still occurring? If it is, I would appreciate that as well as the output of the following in the dev console. I would rather not unlike all my songs to find out!

await Spicetify.Platform.LibraryAPI.getTracks({ limit: Number.MAX_SAFE_INTEGER });
WaddlesPlays commented 2 months ago

The rollback commits seemed to have fixed it, labels now display and I don't see the error in my console anymore. I think it just took marketplace a bit to catch up! If the commits ever happened to be reintroduced, the fix is probably a simple null-check or something. Thanks!

ianrispin commented 2 months ago

This is still an issue for me, but there's a different error showing up in the console: image

duffey commented 2 months ago

@ianrispin That error comes from xpui.js, so I think it's unrelated. However, someone else mentioned the labels aren't showing up for them. If you catch any other errors where it says spicetify-playlist-labels.js please let me know. I will try to find the cause on my Spotify in the meantime.

D3SOX commented 2 months ago

image I get this error with Spotify v1.2.11.916 Spicetify v2.34.1 on Linux Seems like LibraryAPI.getEvents does not exist in this version for whatever reason. Can this maybe polyfilled or somehow support both ways?

Edit: Now they work again, and I didn't really change anything. May this be a timing problem? Like it tries to do it too early.

User094573 commented 2 months ago

OK, something has changed. When I click on the extension icon in the bottom panel, the playlist labels are displayed, but only for songs that are in my "Liked" playlist. The labels for the songs in other playlists do not appear.

duffey commented 2 months ago

@User094573 Please let me know if there are any errors related to playlist labels in the dev console, or any steps I might follow to reproduce the issue.

User094573 commented 2 months ago

@duffey, I must say right away - the labels appeared. All I did was download the Spotify devtools installer script from this gist. I ran it with the "-c" option (clearing the Spotify cache), and the labels finally appeared. However, this only worked on a Linux computer, and not on a Windows one - neither clearing the cache or reinstalling Spicetify entirely helped on the Windows computer.

cariosa commented 2 months ago

Same issue for me, I tried fully uninstalling spicetify and reinstalling it, then it shows up after installing the extension freshly but fails after reloading or restarting. I'm using the old version for the time being but it is not snappy.

User094573 commented 2 months ago

@duffey, I just checked it on my Windows machine and the playlist labels are working fine too. I haven't done anything to change this, it's simply working as expected since I started Spotify.

duffey commented 2 months ago

@User094573 Thanks for letting me know. It might be due to the bugfix I pushed the other day.

duffey commented 2 months ago

@ianrispin Can you let me know if the labels are showing for you now?

D3SOX commented 2 months ago

For me it currently only shows one playlist (which is always Liked Songs if liked) with ellipsis left to it and no possibility to see the others

ianrispin commented 2 months ago

@duffey Yeah, it's showing liked songs as well as some of my playlists, but not nearly all of them.

cariosa commented 3 weeks ago

If anyone's still facing the problem, I got it working by reloading spotify (through installing or uninstalling some unwanted extension). So for me this extension doesn't load at first boot.