search

duganchen / dosbox

GNU General Public License v2.0
28 stars 10 forks source link

GLEW: move lib detection inside the OpenGL check loop #33

Open SupervisedThinking opened 3 years ago

SupervisedThinking commented 3 years ago

With this commit https://github.com/duganchen/dosbox/commit/e6b88ad03202d1f74e329f54f213d3b070bd6202 configure checks if libGLEW is present which depends on OpenGL. So if you try to compile the emulator on systems without OpenGL it will still fail even though --disable-opengl was set.

SupervisedThinking commented 3 years ago

Well I would recommend to use https://github.com/dosbox-staging/dosbox-staging as drop in replacement 👍🏻

duganchen commented 3 years ago

I'm going to leave this open, as it's a valid issue, even though the honest answer is that the whole point of this fork is to provide more features to OpenGL systems and that I could care less about supporting non-OpenGL systems.

SupervisedThinking commented 3 years ago

Well don't get me wrong & no offence but your fork is "superflous" at some point, just check out dosbox-staging & if you can better invest your time & effort to improve this already way superior project.

duganchen commented 3 years ago

FYI: I actually was offered a position on dosbox-staging at one point. https://github.com/dosbox-staging/dosbox-staging/issues/217#issuecomment-603276653

SupervisedThinking commented 3 years ago

@dreamer No thank you.

Well then farewell goodbye adieu & have fun with your fork ^^

dreamer commented 3 years ago

@SupervisedThinking, there's no reason to drag out old discussions.

@duganchen's fork is quality work - I referenced it several times when investigating certain technical decisions, investigating features, etc - and I'm 100% sure I will do it again in the future.

@duganchen - if you will ever change your mind and will plan to work on DOSBox codebase again, my offer for joining forces in DOSBox Staging project still stands :smiley:. Regardless - thank you for the good work you did in the past and careful documentation - it was very helpful to me.

SupervisedThinking commented 3 years ago

@dreamer it's not a discussion, I've used this fork back in the days but it wasn't actively maintained nor fixed for years now. When I updated my packages for latest LE10.0 I realised that the OpenGL detection is somewhat problematic but at the same time I found dosbox-staging which is superior and that's a matter of fact.

I didn't know @duganchen was already asked for collaboration and so I recommended to have a look at dosbox-staging instead of fixing the dated buildchain on a pretty much dead fork.

If he's not interested that's fine but I already moved on.