dugarab / jsplumb

Automatically exported from code.google.com/p/jsplumb
0 stars 0 forks source link

fire connectionDrag event when dragging a new connection #292

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
presently, this event does not fire if the user is dragging a brand new 
connection. it would be good if it did.

should probably send a second parameter down to call out the fact that it's a 
new connection:

connectionDrag(connection, isNew)

Original issue reported on code.google.com by simon.po...@gmail.com on 7 Nov 2012 at 9:32

GoogleCodeExporter commented 8 years ago
fixed in 1.4.0.  but i did not add the second parameter; i decided it was 
unnecessary.

Original comment by simon.po...@gmail.com on 14 Nov 2012 at 3:07

GoogleCodeExporter commented 8 years ago
Thanks Simon! That change works great.

I'm not sure if its related to this change, but I'm seeing an issue with the 
latest sources for 1.4.0:
http://jsfiddle.net/u9BSC/9/

Create a connection from the top to the begin to the phone interview 1 box. 
Then delete it, by clicking on it. Then create the connection again.

In Chrome 23.0.1271.95 on OS X 10.8.2 I get the following error in the console:
jsPlumb function failed : TypeError: Cannot read property 'left' of undefined

Original comment by iann...@gmail.com on 11 Dec 2012 at 7:03

GoogleCodeExporter commented 8 years ago
hmm yeah that looks like a bug doesnt it. let me reopen this one so i dont 
forget to look at it before releasing 1.4.0.

i was doing a jsplumb integration for someone recently and i needed this drag 
event for new connections. i was like, why didn't that stupid jsplumb guy just 
wire up this event to new connections in the first place??

Original comment by simon.po...@gmail.com on 11 Dec 2012 at 7:41

GoogleCodeExporter commented 8 years ago
ok that's fixed now too.

Original comment by simon.po...@gmail.com on 16 Dec 2012 at 8:55

GoogleCodeExporter commented 8 years ago
Thanks Simon, that looks great!

Original comment by iann...@gmail.com on 11 Jan 2013 at 8:00

GoogleCodeExporter commented 8 years ago
Same problem for the 'connectionDragEnd'-event. It doesn't fire for brand new 
connections.

Original comment by muluh...@gmail.com on 8 May 2013 at 2:52

GoogleCodeExporter commented 8 years ago
there is no connectionDragEnd event. it is connectionDragStop.

I am no longer using google code for jsPlumb.

Original comment by simon.po...@gmail.com on 10 May 2013 at 11:36