search

duhowise / TransPoster

TransPorter
2 stars 1 forks source link

Database Explorer not implemented well #44

Open YehudahA opened 1 year ago

YehudahA commented 1 year ago

It's implemented as Model/ViewModel proccesser.

But from the specification document:

The solution must be generic, ready for reuse for every table in the world.

duhowise commented 1 year ago

Not an issue at all. The current implementation is due to repurposing the supplied code on time for the POC I'll have a discussion with the team to do a refactoring.

We can refractor the logic into tag helpers for instance.

On Mon, 6 Feb 2023, 11:18 Yehudah A-N, @.***> wrote:

It's implemented as Model/ViewModel proccesser.

But from the specification document:

The solution must be generic, ready for reuse for every table in the world.

— Reply to this email directly, view it on GitHub https://github.com/duhowise/TransPoster/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFYIESMRYM4LQGINO4H7VLWWDMYTANCNFSM6AAAAAAUSRQJHM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

duhowise commented 1 year ago

What's your suggested approach?

On Mon, 6 Feb 2023, 11:36 Wise Duho, @.***> wrote:

Not an issue at all. The current implementation is due to repurposing the supplied code on time for the POC I'll have a discussion with the team to do a refactoring.

We can refractor the logic into tag helpers for instance.

On Mon, 6 Feb 2023, 11:18 Yehudah A-N, @.***> wrote:

It's implemented as Model/ViewModel proccesser.

But from the specification document:

The solution must be generic, ready for reuse for every table in the world.

— Reply to this email directly, view it on GitHub https://github.com/duhowise/TransPoster/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFYIESMRYM4LQGINO4H7VLWWDMYTANCNFSM6AAAAAAUSRQJHM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

YehudahA commented 1 year ago

Let see my code, that merged by you.

This is just a sketch that has not been tested by me. The development should be focused in 3 parts:

  1. In the side nav, create links for all dbset's.
  2. In the index, create <th> for all properties. Note that we have to create to rows of <th>, as we did already in DataTableTagHelper
  3. In the processor, implement all methods. DataTableProccesserBase can give you good inspiration. Note that DbSetProccesser is simpler, because it's doesn't process navigation properties.