search

duiqt / herta_kuru

The website for Herta, the cutest genius Honkai: Star Rail character out there.
712 stars 161 forks source link

Add multi-language support #15

Closed fred913 closed 1 year ago

fred913 commented 1 year ago

according to issue #13 I have added Chinese language support (text and voice files) and the experience is good (because I'm native Chinese). Contributions for other languages are welcomed! It is easy to add them, just see inside script.js.

duiqt commented 1 year ago

i will look into it in abit after i get home. thanks for helping out!

TororuInta commented 1 year ago

according to issue #13 I have added Chinese language support (text and voice files) and the experience is good (because I'm native Chinese). Contributions for other languages are welcomed! It is easy to add them, just see inside script.js.

I want to contribute for another language, should I do a new pull request?

duiqt commented 1 year ago

Either a pull request and we will look into it or you post thr code in js here so we can check out here and ađ it later.

fred913 commented 1 year ago

@TororuInta Yes. The multi language data is stored in the js file. You should create a PR to modify it.

On Thu, Jun 1, 2023, 12:17 AM Phúc Duy @.***> wrote:

Either a pull request and we will look into it or you post thr code in js here so we can check out here and ađ it later.

— Reply to this email directly, view it on GitHub https://github.com/duiqt/herta_kuru/pull/15#issuecomment-1570533324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ7IKHYZODHD5LWKJTFO2HLXI5VIJANCNFSM6AAAAAAYRFA2PY . You are receiving this because you authored the thread.Message ID: @.***>