search

duiqt / herta_kuru

The website for Herta, the cutest genius Honkai: Star Rail character out there.
712 stars 161 forks source link

feat: make the number update much smoother #19

Closed fred913 closed 1 year ago

fred913 commented 1 year ago

also improves the code style, and make the animation logic easier to understand

fred913 commented 1 year ago

needs to be reviewed since hidden problems are there

risbi0 commented 1 year ago

updateGlobalCount is called 3-4 times during load when the site tab is active. Please fix that as it brings additional unnecessary load to the server. I also specifically wrote the code to animate the display in a short amount of time. The animation right now is still not seamless, and even then, pushing the button will stop the animation so it won't be totally seamless anyway.