duiqt / herta_kuru

The website for Herta, the cutest genius Honkai: Star Rail character out there.
712 stars 161 forks source link

Feature: dynamic texts, and few style moderations. #25

Closed PencilCore closed 1 year ago

PencilCore commented 1 year ago

Let the button and texts be dynamic when clicking! Herta is god, again.

PencilCore commented 1 year ago

@fred913 你知道日语还有别的两种方式显示“黑塔已经转了”这段文字吗 如果有告诉我我来加,或者你也可以自己加(

PencilCore commented 1 year ago

@fred913 你知道日语还有别的两种方式显示“黑塔已经转了”这段文字吗 如果有告诉我我来加,或者你也可以自己加(

这样应该就不报错了,就是少一段文本

PencilCore commented 1 year ago

先弄俩一样的好了,之后再加

PencilCore commented 1 year ago

@fred913 谢谢改进。

fred913 commented 1 year ago

我的想法是,可以把翻译文字的替换改改,比如这样的格式:

texts: {
            "page-title": "黑塔转圈圈~",
            "doc-title": "咕噜噜~",
            "page-descriptions": "给黑塔酱写的小网站,对,就是那个<del>烦人的</del>最可爱的《崩坏:星穹铁道》角色!",
            "counter-descriptions": ["黑塔已经咕噜噜~了", "黑塔已经转了"],
            "counter-unit": ["次", "次圈圈"],
            "counter-button": ["转圈圈~", "咕噜噜!"],
            "credits-gif": "黑塔GIF作者:",
            "footer-repository-text": "源代码在此:",
            "footer-repository-text-2": "herta_kuru 仓库"
        }
fred913 commented 1 year ago

代码普适性会更强,当然只是个人建议

PencilCore commented 1 year ago

@fred913 懒得改了,可以修改一下switchDescription()下的对象获取方法。以后再看吧。

fred913 commented 1 year ago

我待会去改改

On Sun, May 28, 2023, 10:38 PM Pencil @.***> wrote:

@fred913 https://github.com/fred913 懒得改了,可以修改一下switchDescription()下的对象获取方法。以后再看吧。

— Reply to this email directly, view it on GitHub https://github.com/duiqt/herta_kuru/pull/25#issuecomment-1566159479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ7IKH3QUBCAMCYHXG6OVIDXINPMZANCNFSM6AAAAAAYR4D6XY . You are receiving this because you were mentioned.Message ID: @.***>

PencilCore commented 1 year ago

加油喵

我待会去改改 On Sun, May 28, 2023, 10:38 PM Pencil @.> wrote: @fred913 https://github.com/fred913 懒得改了,可以修改一下switchDescription()下的对象获取方法。以后再看吧。 — Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ7IKH3QUBCAMCYHXG6OVIDXINPMZANCNFSM6AAAAAAYR4D6XY . You are receiving this because you were mentioned.Message ID: @.>

PencilCore commented 1 year ago

Request another check

fred913 commented 1 year ago

Working without problems, can merge without issues