Fix naming issues and add extra documents

duk3luk3 / onion-py

Python wrapper for the OnionOO tor status API

Other

32 stars 17 forks source link

Fix naming issues and add extra documents #2

Closed baumanno closed 10 years ago

baumanno commented 10 years ago

These commits fix typos in field names and add the extra BridgeUptime-object present in the onionoo-protocol specs.

duk3luk3 commented 10 years ago

Thanks for this PR! Some notes:

Your BridgeUptime class is identical to RelayUptime. I suppose in the name of OOP it makes sense to include it.
You forgot to actually use the BridgeUptime class in the Uptime document constructor. I'll add that.
Please prepare a feature branch off of upstream master (i.e. my repo's master branch) that only contains the commits you want to merge the next time you want to make a PR, that makes it a lot easier to check it out and review for me.

baumanno commented 10 years ago

I concur with all your remarks and apologize for the incomplete Uptime-constructor, I must have missed that. Could you ship a new version to PyPi including these changes? I'm hacking on a tor-globe/atlas successor and it would be immensly awesome not having to point pip to my github-fork ;)

duk3luk3 commented 10 years ago

I already wanted to do that but my signing key expired a few weeks ago and my primary keypair is hidden behind the crocodile-filled moat. It'll probably take a few days until I've fixed that...

EDIT: Well - I uploaded unsigned files to pypi for now.

baumanno commented 10 years ago

Great, thanks a lot!

duk3luk3 commented 10 years ago

(Release 0.2.2 is on pypi and is signed)