search

duke-automation / net-ssh-telnet

A ruby module to provide a simple send/expect interface over SSH with an API almost identical to Net::Telnet. Ideally it should be a drop in replacement. Please see Net::Telnet for main documentation (included with ruby stdlib).
7 stars 4 forks source link

add require statement for Net::ReadTimeout exception #8

Closed electricalen closed 3 years ago

electricalen commented 3 years ago

When there is a timeout running a command, it tries to raise a Net::ReadTimeout exception which is in the net/http library but not included in the requires.

seandilda commented 3 years ago

Thanks for reporting this. It looks like Net::ReadTimeout is defined in 'net/protocol' which is used by net/http, net/ftp, net/smtp, net/pop, and net/imap.

What do you think of switching from net/http to net/protocol so that users can pull in the minimum required libraries?

electricalen commented 3 years ago

@seandilda Yes that's probably better, I updated it.

seandilda commented 3 years ago

Thanks!