Javascript style - Githubissues

dylanfprice commented 3 years ago

Here is a collection of small changes to bring it up to modern js syntax and conventions. I ordered them by what I feel is most important first.

=== instead of == (https://stackoverflow.com/a/359509)
pascalCase instead of snake_case
- I prefer snake_case too but this is how js is written, best not to fight it IMO
let or const instead of var
if you are going to only have one file you would call it index.js instead of surveyjs-fhir.js
item.answer instead of item['answer']
if you want: (page, page_index) => { instead of function (page, page_index) { for anonymous functions
use ES6 modules instead of CommonJS:
- Browsers do not support CommonJS modules, but they do support ES6 modules. ES6 modules are the modern standard but support in Node is relatively recent so I don't know how easy it is. Since a downstream consumer of this library would most likely be using webpack to bundle their code into a single script, CommonJS modules are probably ok (webpack can resolve them).
- If you want to switch to ES6:
  - import instead of require()
  - export statement instead of module.exports =
  - need to have node > 13.2 and add {"type": "module"} to package.json. May also need to pass --experimental-specifier-resolution=node to node?

theGOTOguy commented 3 years ago

theGOTOguy commented 3 years ago

All issues now addressed. Thank you for the helpful tips!

duke-crucible / surveyjs-fhir