search

dukechronicle / chronjs

Source code for a former version of dukechronicle.com
dukechronicle.com
8 stars 1 forks source link

Ad-Blocker causing Alignment Script to Fail #358

Open tylernisonoff opened 11 years ago

grivkees commented 11 years ago

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

deanchen commented 11 years ago

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees notifications@github.comwrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611.

jimpo commented 11 years ago

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080.

-Jim

jodoglevy commented 11 years ago

I think you guys should put really disgusting photos (maybe of Glenn's face) behind where the ads go, so if someone uses ad blocker to remove the ads they find something even more repulsive in their place

On Wed, Sep 26, 2012 at 4:43 PM, Jim Posen notifications@github.com wrote:

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080>.

-Jim

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8911415.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

ethanngoh commented 11 years ago

Chrome plugin evolution

ad-block -> cat-block -> glenn-block

Ethan Goh

On Wed, Sep 26, 2012 at 4:45 PM, Joe Levy notifications@github.com wrote:

I think you guys should put really disgusting photos (maybe of Glenn's face) behind where the ads go, so if someone uses ad blocker to remove the ads they find something even more repulsive in their place

On Wed, Sep 26, 2012 at 4:43 PM, Jim Posen notifications@github.com wrote:

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees < notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080>.

-Jim

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911415>.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8911520.

deanchen commented 11 years ago

Quick Joe, make a chrome extension and maybe techcrunch will pick it up again.

On Wed, Sep 26, 2012 at 5:01 PM, Ethan Goh notifications@github.com wrote:

Chrome plugin evolution

ad-block -> cat-block -> glenn-block

Ethan Goh

On Wed, Sep 26, 2012 at 4:45 PM, Joe Levy notifications@github.com wrote:

I think you guys should put really disgusting photos (maybe of Glenn's face) behind where the ads go, so if someone uses ad blocker to remove the ads they find something even more repulsive in their place

On Wed, Sep 26, 2012 at 4:43 PM, Jim Posen notifications@github.com wrote:

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees < notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080>.

-Jim

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911415>.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911520>.

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8912981.

jodoglevy commented 11 years ago

I try to get us blogging, even get us to the point of being featured in suntrust, and still no one on chronline blogs!

On Wed, Sep 26, 2012 at 6:23 PM, Dean Chen notifications@github.com wrote:

Quick Joe, make a chrome extension and maybe techcrunch will pick it up again.

On Wed, Sep 26, 2012 at 5:01 PM, Ethan Goh notifications@github.com wrote:

Chrome plugin evolution

ad-block -> cat-block -> glenn-block

Ethan Goh

On Wed, Sep 26, 2012 at 4:45 PM, Joe Levy notifications@github.com wrote:

I think you guys should put really disgusting photos (maybe of Glenn's face) behind where the ads go, so if someone uses ad blocker to remove the ads they find something even more repulsive in their place

On Wed, Sep 26, 2012 at 4:43 PM, Jim Posen notifications@github.com wrote:

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees < notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080>.

-Jim

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911415>.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911520>.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8912981>.

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8915564.

jodoglevy commented 11 years ago

*techcrunch

On Wed, Sep 26, 2012 at 6:25 PM, Joe Levy jodoglevy@gmail.com wrote:

I try to get us blogging, even get us to the point of being featured in suntrust, and still no one on chronline blogs!

On Wed, Sep 26, 2012 at 6:23 PM, Dean Chen notifications@github.comwrote:

Quick Joe, make a chrome extension and maybe techcrunch will pick it up again.

On Wed, Sep 26, 2012 at 5:01 PM, Ethan Goh notifications@github.com wrote:

Chrome plugin evolution

ad-block -> cat-block -> glenn-block

Ethan Goh

On Wed, Sep 26, 2012 at 4:45 PM, Joe Levy notifications@github.com wrote:

I think you guys should put really disgusting photos (maybe of Glenn's face) behind where the ads go, so if someone uses ad blocker to remove the ads they find something even more repulsive in their place

On Wed, Sep 26, 2012 at 4:43 PM, Jim Posen notifications@github.com

wrote:

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees < notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080>.

-Jim

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911415>.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911520>.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8912981>.

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8915564.

grivkees commented 11 years ago

Ohh joes getting us featured by medium sized south eastern banks! We fancy huh. On Sep 27, 2012 2:26 AM, "Joe Levy" notifications@github.com wrote:

*techcrunch

On Wed, Sep 26, 2012 at 6:25 PM, Joe Levy jodoglevy@gmail.com wrote:

I try to get us blogging, even get us to the point of being featured in suntrust, and still no one on chronline blogs!

On Wed, Sep 26, 2012 at 6:23 PM, Dean Chen notifications@github.comwrote:

Quick Joe, make a chrome extension and maybe techcrunch will pick it up again.

On Wed, Sep 26, 2012 at 5:01 PM, Ethan Goh notifications@github.com wrote:

Chrome plugin evolution

ad-block -> cat-block -> glenn-block

Ethan Goh

On Wed, Sep 26, 2012 at 4:45 PM, Joe Levy notifications@github.com wrote:

I think you guys should put really disgusting photos (maybe of Glenn's face) behind where the ads go, so if someone uses ad blocker to remove the ads they find something even more repulsive in their place

On Wed, Sep 26, 2012 at 4:43 PM, Jim Posen < notifications@github.com>

wrote:

They are, but the div is labeled as class "advertisement", so the entire div gets removed, which is probably desirable (aside from the alignment not running).

-Jim

On Wednesday, September 26, 2012, Dean Chen wrote:

Shouldn't be a problem in the first place if all ads are contained in divs with height and width.

I happen to use ad block so let's not hate on the ad block users too much here. :P

On Wed, Sep 26, 2012 at 4:01 PM, Glenn Rivkees < notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>wrote:

The align script only runs once, right after the page has finished rendering. Adblockers wait the the page has finished rendering (that includes the align), and then remove the ads. It would be inefficient to redo the align just for ad blockers, especially when that shouldn't be a supported use case as they just make us lose money.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8909611>.

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911080>.

-Jim

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911415>.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

— Reply to this email directly or view it on GitHub<

https://github.com/thechronicle/chronjs/issues/358#issuecomment-8911520>.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8912981>.

— Reply to this email directly or view it on GitHub< https://github.com/thechronicle/chronjs/issues/358#issuecomment-8915564>.

— Reply to this email directly or view it on GitHubhttps://github.com/thechronicle/chronjs/issues/358#issuecomment-8915612.