Photoshelter Galleries

[jimpo]

Before pushing to production, I want to consolidate all migrations into one. It's just a matter of recreating your local database.

[jimpo]

Change the Photos link on the nav.

[tylernisonoff]

That protip was too good not to use

[jimpo]

You should parse out the dates from the titles and let them edit both. The titles are pretty ugly right now.

[jimpo]

Since the thumbnail sizes/ratios are all different, instead of a row layout, you might want to try using masonry. I think it will look better.

[tylernisonoff]

RE: You should parse out the dates from the titles and let them edit both. The titles are pretty ugly right now.

What do you mean by edit both?

[jimpo]

From the admin interface they should be able to edit both the gallery title and the gallery date. Though now that I look at is, is the date in the title the same as the uploaded_at date?

[tylernisonoff]

Right now we aren't grabbing the uploaded_at, I've just been using created_at - should we add another date field to galleries?

On Thu, Jan 2, 2014 at 6:04 PM, Jim Posen notifications@github.com wrote:

From the admin interface they should be able to edit both the gallery title and the gallery date. Though now that I look at is, is the date in the title the same as the uploaded_at date?

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/156#issuecomment-31492865 .

[jimpo]

Yes, probably. Ask Thanh-ha.

[jimpo]

I realized you probably want to use slugs for galleries for SEO reasons.

[tylernisonoff]

Okay I'll add that to the list

Edit - resolved On Sun, Jan 12, 2014 at 9:12 PM, Jim Posen notifications@github.com wrote:

I realized you probably want to use slugs for galleries for SEO reasons.

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/156#issuecomment-32141687 .

[jimpo]

80 characters per line max! (except in HAML)

[jimpo]

Why are there so many updated gems in the Gemfile.lock? Are they all tested/safe?

[jimpo]

Are you able to determine the widths/heights of images statically and add them as an attribute on tags? It helps when rendering the page.

[tylernisonoff]

About the gemfile.lock - I don't know why this changed so much

[jimpo]

I'm nervous about the Gemfile. Run

$ git checkout HEAD Gemfile.lock
$ bundle install

[tylernisonoff]

I checked out Gemfile.lock from Rodgers discussion board merge and then ran bundle install

[jimpo]

LGTM