dukechronicle / chronline

The official repository for the Duke Chronicle website
http://www.dukechronicle.com
202 stars 21 forks source link

Refactor Taxonomy #157

Closed jimpo closed 10 years ago

jimpo commented 10 years ago

Taxonomy class has been given some love. The concept of taxonomy terms got kind of messed up with the Camayak integration. Now you can have multiple namespaced taxonomy trees. The main one (sections) are used for articles, and there is a second, separate blog taxonomy tree.

deanchen commented 10 years ago

Someone has been busy over break.

On Thu, Jan 2, 2014 at 2:59 PM, Jim Posen notifications@github.com wrote:

Taxonomy class has been given some love. The concept of taxonomy terms got kind of messed up with the Camayak integration. Now you can have multiple namespaced taxonomy trees. The main one (sections) are used for articles,

and there is a second, separate blog taxonomy tree.

You can merge this Pull Request by running

git pull https://github.com/dukechronicle/chronline taxonomy

Or view, comment on, or merge it at:

https://github.com/dukechronicle/chronline/pull/157 Commit Summary

  • Blogs are in the taxonomy config file.
  • Created supporting functions for blog to taxonomy conversion.
  • Navbar on blog index page links to category pages.
  • Merge branch 'master' into taxonomy
  • Taxonomy terms can come in different trees. Updated specs.
  • Correctly serialize and deserialize sections in posts.
  • Taxonomy validator validates taxonomy.
  • Cleaned up taxonomy_spec.
  • Updated Blog model and specs.
  • Moved popularity code from Article to Post.
  • Writing more Post model specs.
  • Post specs complete except for some pending tests.
  • All model specs up to date and passing.
  • Fixed desktop and mobile sites.
  • Removed unnecessary blog configuration.
  • Making API tests pass.
  • Figured out how to autoload lib while using initializers.
  • Global @@taxonomy doesn't work.
  • Merge branch 'master' into taxonomy
  • All tests passing.

File Changes

  • M app/controllers/admin/articles_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-0(2)
  • M app/controllers/api/articles_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-1(2)
  • M app/controllers/api/posts_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-2(9)
  • M app/controllers/api/taxonomy_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-3(6)
  • M app/controllers/mobile/articles_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-4(2)
  • M app/controllers/rss/articles_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-5(2)
  • M app/controllers/site/articles_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-6(2)
  • M app/controllers/site/blog_posts_controller.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-7(18)
  • M app/helpers/blog_post_helper.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-8(8)
  • M app/helpers/taxonomy_helper.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-9(18)
  • M app/models/article.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-10(71)
  • M app/models/blog.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-11(88)
  • M app/models/blog/post.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-12(16)
  • M app/models/post.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-13(170)
  • M app/views/admin/articles/index.html.hamlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-14(2)
  • M app/views/site/blog_posts/_index.html.hamlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-15(2)
  • M app/views/site/blog_posts/index.html.hamlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-16(2)
  • M app/views/site/partials/_blog-info.html.hamlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-17(2)
  • M app/views/site/partials/_header.html.hamlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-18(4)
  • M config/application.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-19(2)
  • M config/blogs.ymlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-20(32)
  • M config/initializers/redis.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-21(2)
  • M config/initializers/sitevars.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-22(1)
  • A config/initializers/taxonomy.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-23(8)
  • M config/routes.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-24(5)
  • M db/seeds.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-25(8)
  • M lib/layout/schemata.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-26(2)
  • M lib/sitevar.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-27(3)
  • M lib/taxonomy.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-28(123)
  • M lib/taxonomy/errors.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-29(11)
  • M lib/taxonomy/serializer.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-30(8)
  • M lib/taxonomy/validator.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-31(18)
  • M spec/config/blogs.ymlhttps://github.com/dukechronicle/chronline/pull/157/files#diff-32(10)
  • M spec/factories.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-33(5)
  • M spec/lib/taxonomy_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-34(147)
  • M spec/models/article_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-35(93)
  • M spec/models/blog_post_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-36(16)
  • M spec/models/blog_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-37(56)
  • M spec/models/post_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-38(161)
  • M spec/requests/api/posts_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-39(2)
  • M spec/requests/api/taxonomy_spec.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-40(2)
  • M spec/spec_helper.rbhttps://github.com/dukechronicle/chronline/pull/157/files#diff-41(10)

Patch Links:

jodoglevy commented 10 years ago

Who let dean on here??

On Thu, Jan 2, 2014 at 6:22 PM, Dean Chen notifications@github.com wrote:

Someone has been busy over break.

On Thu, Jan 2, 2014 at 2:59 PM, Jim Posen notifications@github.com wrote:

Taxonomy class has been given some love. The concept of taxonomy terms got kind of messed up with the Camayak integration. Now you can have multiple namespaced taxonomy trees. The main one (sections) are used for articles,

and there is a second, separate blog taxonomy tree.

You can merge this Pull Request by running

git pull https://github.com/dukechronicle/chronline taxonomy

Or view, comment on, or merge it at:

https://github.com/dukechronicle/chronline/pull/157 Commit Summary

  • Blogs are in the taxonomy config file.
  • Created supporting functions for blog to taxonomy conversion.
  • Navbar on blog index page links to category pages.
  • Merge branch 'master' into taxonomy
  • Taxonomy terms can come in different trees. Updated specs.
  • Correctly serialize and deserialize sections in posts.
  • Taxonomy validator validates taxonomy.
  • Cleaned up taxonomy_spec.
  • Updated Blog model and specs.
  • Moved popularity code from Article to Post.
  • Writing more Post model specs.
  • Post specs complete except for some pending tests.
  • All model specs up to date and passing.
  • Fixed desktop and mobile sites.
  • Removed unnecessary blog configuration.
  • Making API tests pass.
  • Figured out how to autoload lib while using initializers.
  • Global @@taxonomy doesn't work.
  • Merge branch 'master' into taxonomy
  • All tests passing.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/157#issuecomment-31493852 .

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

deanchen commented 10 years ago

Shouldn't you be working right now? Oh right, PMs don't do any work.

On Thu, Jan 2, 2014 at 3:24 PM, Joe Levy notifications@github.com wrote:

Who let dean on here??

On Thu, Jan 2, 2014 at 6:22 PM, Dean Chen notifications@github.com wrote:

Someone has been busy over break.

On Thu, Jan 2, 2014 at 2:59 PM, Jim Posen notifications@github.com wrote:

Taxonomy class has been given some love. The concept of taxonomy terms got kind of messed up with the Camayak integration. Now you can have multiple namespaced taxonomy trees. The main one (sections) are used for articles,

and there is a second, separate blog taxonomy tree.

You can merge this Pull Request by running

git pull https://github.com/dukechronicle/chronline taxonomy

Or view, comment on, or merge it at:

https://github.com/dukechronicle/chronline/pull/157 Commit Summary

  • Blogs are in the taxonomy config file.
  • Created supporting functions for blog to taxonomy conversion.
  • Navbar on blog index page links to category pages.
  • Merge branch 'master' into taxonomy
  • Taxonomy terms can come in different trees. Updated specs.
  • Correctly serialize and deserialize sections in posts.
  • Taxonomy validator validates taxonomy.
  • Cleaned up taxonomy_spec.
  • Updated Blog model and specs.
  • Moved popularity code from Article to Post.
  • Writing more Post model specs.
  • Post specs complete except for some pending tests.
  • All model specs up to date and passing.
  • Fixed desktop and mobile sites.
  • Removed unnecessary blog configuration.
  • Making API tests pass.
  • Figured out how to autoload lib while using initializers.
  • Global @@taxonomy doesn't work.
  • Merge branch 'master' into taxonomy
  • All tests passing.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/dukechronicle/chronline/pull/157#issuecomment-31493852>

.

Joe Levy Duke University '12, Computer Science www.jodoglevy.com 919.886.6563

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/157#issuecomment-31493999 .

jimpo commented 10 years ago

This is only the beginning.

deanchen commented 10 years ago

Haha, what happened to "I'm going to hand off everything at the start of the spring semester?"?

On Thu, Jan 2, 2014 at 3:37 PM, Jim Posen notifications@github.com wrote:

This is only the beginning.

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/157#issuecomment-31494725 .

grivkees commented 10 years ago

School doesn't start until Wed.


Glenn Rivkees Duke University Pratt School of Engineering '14 email glenn.rivkees@gmail.com cell 321/277-7587

On Thu, Jan 2, 2014 at 6:39 PM, Dean Chen notifications@github.com wrote:

Haha, what happened to "I'm going to hand off everything at the start of the spring semester?"?

On Thu, Jan 2, 2014 at 3:37 PM, Jim Posen notifications@github.com wrote:

This is only the beginning.

— Reply to this email directly or view it on GitHub< https://github.com/dukechronicle/chronline/pull/157#issuecomment-31494725>

.

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/157#issuecomment-31494796 .

deanchen commented 10 years ago

So Jim is planning on rewriting the entire codebase in less than a week?

On Thu, Jan 2, 2014 at 4:11 PM, Glenn Rivkees notifications@github.comwrote:

School doesn't start until Wed.


Glenn Rivkees Duke University Pratt School of Engineering '14 email glenn.rivkees@gmail.com cell 321/277-7587

On Thu, Jan 2, 2014 at 6:39 PM, Dean Chen notifications@github.com wrote:

Haha, what happened to "I'm going to hand off everything at the start of the spring semester?"?

On Thu, Jan 2, 2014 at 3:37 PM, Jim Posen notifications@github.com wrote:

This is only the beginning.

— Reply to this email directly or view it on GitHub<

https://github.com/dukechronicle/chronline/pull/157#issuecomment-31494725>

.

— Reply to this email directly or view it on GitHub< https://github.com/dukechronicle/chronline/pull/157#issuecomment-31494796>

.

— Reply to this email directly or view it on GitHubhttps://github.com/dukechronicle/chronline/pull/157#issuecomment-31496408 .

jimpo commented 10 years ago

Mostly gonna be writing tests and stuff.