Closed shanbhardwaj closed 7 years ago
Thanks for the report. I haven't seen this with gcc 4.8, gcc 6.3, gcc 7.1, or clang 4.0.
@junyer, should we track the ICE here or in google/re2#148?
It's unfortunate, but we have to deal with this until Ubuntu fixes their gcc package. Since Ubuntu 16.04 is an LTS release, perhaps RE2 should, if possible, identify and work around the gcc regression as done in another case (google/re2#102). In fact, I would suspect this to pop up when Ubuntu 16.04 packages an affected libre2
release or when Chrome debs do the same. Maybe the Chrome team or Ubuntu already incorporated a patch.
Short-term fixes or workarounds:
CXX=clang++
when building.SYSTEM_RE2=1
when building and have it use libre2-dev
as available in Ubuntu's repo.RE2_REV=<some_rev>
and pick a release/commit that doesn't trigger the ICE.RE2_REV
, but this is a bad idea since any change of RE2_REV
would be unnecessarily involved. I would prefer not to do this if we can avoid it.Either way, do you mind reporting the ICE at Ubuntu or gcc.gnu.org?
@tuncer I just moved on and compiled with gcc-7. Thanks for the writeup and the help. You can close the issue if you'd like.
@shanbhardwaj, can you please test with the v1.7.7
release with your original environment? The only change is that RE2_REV
defaults to 2017-07-01
.
@junyer, thinking about it, we should be able to utilize Travis-CI or GitLab-CI to build and test with different gcc versions or even different Linux distro chroots/containers. This seems like a low effort task to ensure that no RE2 commit fails on stable and/or LTS Linux distros, and can be relied upon prior to merging things, or at least to report the state of master
. Filed as https://github.com/google/re2/issues/149.
Acknowledged.
Now that google/re2#149 has been resolved (thanks @junyer!), we can close this ticket.
However, I tried reproducing the ICE on Ubuntu 16.04.4 with 2017-01-01
, 2017-05-01
, 2017-06-01
, and it never ICE'd for me. The issue is resolved, but I'm still curious what I did wrong or why the ICE didn't surface here. Any ideas?
I'm willing to chalk this up to a glitch in the matrix. We've done our due diligence, I believe, so unless the ICE resurfaces (via build breakage or another report) or @shanbhardwaj wants to dig into it, let's just close this issue.
Agreed.
I am trying to compile from head and running into the following issue
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4) Erlang/OTP version: (19.3.6)
I have also built https://github.com/google/re2 separately from HEAD and installed it on the box but still running into the same issue. Here are the results of test install for re2