dukke / FXRibbon

Ribbon control for Java, created in JavaFX
http://www.pixelduke.com/fxribbon
244 stars 46 forks source link

right to left support #10

Open am2222 opened 6 years ago

am2222 commented 6 years ago

Hi, Does this Ribbon supports Right to left languages such as Arabic? thanks

dukke commented 6 years ago

Hi,

No, not right now.

am2222 commented 6 years ago

@dukke thanks very much, is it possible to give me some hints about how can I do that? I am familiar with css but have no idea if I can use its related commands in javafx and make it right to left or not? thanks

dukke commented 6 years ago

Hi @am2222 !

First of all I don't really know how this is done. I've quickly searched the web but don't see any references about this in the microsoft ribbon..

Can you check and see if you find anything on how microsoft does this? I don't mean code wise, I mean how microsoft ribbon works in this case from a user point of view.

Thanks!

am2222 commented 6 years ago

@dukke hi, You mean the way that a RTL ribbon is shown?Does it matter about the language? for example I have a few C# ribbon controls which are RTL I can share them if they are usefull

dukke commented 6 years ago

Yes.

I would want to know how the official Microsoft Ribbon handles this..

Thanks,

am2222 commented 6 years ago

@dukke this is an example of RTL ribbon, But it is from devexpress C# controls but all the ribbons are just the same as this one

sketch
dukke commented 6 years ago

Sounds good to me!

am2222 commented 6 years ago

@dukke Is there any chance to make it right to left? or if you please give me some hints I'll try by myself, I am new with javafx anyway

dukke commented 6 years ago

Yes I can help you if you want To file a PR..

On Sat, 7 Apr 2018 at 19:12, Majid Hojati notifications@github.com wrote:

@dukke https://github.com/dukke Is there any chance to make it right to left? or if you please give me some hints I'll try by myself, I am new with javafx anyway

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dukke/FXRibbon/issues/10#issuecomment-379488632, or mute the thread https://github.com/notifications/unsubscribe-auth/AClQH6nOxGw6TIci4SkZnmr3LbakffP1ks5tmQF6gaJpZM4TJyFd .

-- Pedro Duque Vieira

am2222 commented 6 years ago

@dukke thanks very much so if it is possible please tell me which files should be edited thanks

dukke commented 6 years ago

I've been doing some testing and this actually seems quite easy to do. I can do it myself or you could do it if you want to learn the basics for future contributions?

dukke commented 6 years ago

A solution is:

That's it, I think..

dukke commented 6 years ago

Also a test class in the Test folder that shows a RTL ribbon working would be nice..

am2222 commented 6 years ago

@dukke thanks very much, I'll try to do it myself, I hope I can manage to do it. thanks very much