Update ThemeWindowManagerFactory.java

dukke / FXThemes

Utility classes for advanced Theme development for JavaFX (Java)

https://pixelduke.com/fxthemes

38 stars 5 forks source link

Update ThemeWindowManagerFactory.java #6

Closed regice202 closed 3 months ago

regice202 commented 3 months ago

Provides more robust handling for different Operating Systems and their major versions.

regice202 commented 3 months ago

@dukke Please review PR.

dukke commented 3 months ago

This PR makes a nice tweak to the way we return the appropriate ThemeWindowManager... I just left some minor change suggestion, can you check please?

dukke commented 3 months ago

Merged. Thanks for this PR @regice202 !

regice202 commented 3 months ago

Awesome! Thanks for merging that @dukke. 😁 Any idea when this will be pushed to the Maven repo? You might also want to update the version in the README for the maven repo as well. There's probably a way to automate it, I'm just not sure how.