Closed dukris closed 1 year ago
No, but I can add an integration test for elasticsearch
@hizmailovich Sure, do it we need to verify whether it's working or not
@hizmailovich ready to merge
@rultor merge
@rultor merge
@h1alexbel Thanks for your request; @hizmailovich please confirm this.
@rultor merge
Codecov Report
Patch coverage:
78.43
% and project coverage change:+4.01
:tada:Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #34 +/- ## ============================================ + Coverage 47.47% 51.49% +4.01% - Complexity 66 78 +12 ============================================ Files 27 29 +2 Lines 238 268 +30 Branches 2 8 +6 ============================================ + Hits 113 138 +25 - Misses 125 128 +3 - Partials 0 2 +2 ``` | [Impacted Files](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich) | Coverage Δ | | |---|---|---| | [...ain/java/com/solvd/movie/web/config/WebConfig.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2NvbmZpZy9XZWJDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...om/solvd/movie/web/controller/MovieController.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2NvbnRyb2xsZXIvTW92aWVDb250cm9sbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...rc/main/java/com/solvd/movie/web/dto/MovieDto.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2R0by9Nb3ZpZUR0by5qYXZh) | `0.00% <ø> (ø)` | | | [...olvd/movie/web/dto/criteria/SearchCriteriaDto.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2R0by9jcml0ZXJpYS9TZWFyY2hDcml0ZXJpYUR0by5qYXZh) | `0.00% <ø> (ø)` | | | [...va/com/solvd/movie/web/dto/mapper/MovieMapper.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2R0by9tYXBwZXIvTW92aWVNYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [src/main/java/com/solvd/movie/model/Quality.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvUXVhbGl0eS5qYXZh) | `66.66% <66.66%> (ø)` | | | [...m/solvd/movie/service/impl/EsMovieServiceImpl.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvc2VydmljZS9pbXBsL0VzTW92aWVTZXJ2aWNlSW1wbC5qYXZh) | `95.00% <92.85%> (-5.00%)` | :arrow_down: | | [src/main/java/com/solvd/movie/model/EsMovie.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvRXNNb3ZpZS5qYXZh) | `80.00% <100.00%> (ø)` | | | [src/main/java/com/solvd/movie/model/Movie.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvTW92aWUuamF2YQ==) | `83.33% <100.00%> (+1.51%)` | :arrow_up: | | [...com/solvd/movie/model/criteria/SearchCriteria.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvY3JpdGVyaWEvU2VhcmNoQ3JpdGVyaWEuamF2YQ==) | `100.00% <100.00%> (+50.00%)` | :arrow_up: | | ... and [2 more](https://app.codecov.io/gh/hizmailovich/movie-service/pull/34?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich) | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.