dukris / movie-service

Microservice for "Movie App"
1 stars 0 forks source link

Integration tests for elasticsearch #36

Closed dukris closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 2.17% and project coverage change: -14.78 :warning:

Comparison is base (c2e0e0b) 51.49% compared to head (43f3eb4) 36.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #36 +/- ## ============================================= - Coverage 51.49% 36.71% -14.78% + Complexity 78 64 -14 ============================================= Files 29 37 +8 Lines 268 286 +18 Branches 8 2 -6 ============================================= - Hits 138 105 -33 - Misses 128 181 +53 + Partials 2 0 -2 ``` | [Impacted Files](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich) | Coverage Δ | | |---|---|---| | [.../persistence/builder/impl/CriteriaBuilderImpl.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvYnVpbGRlci9pbXBsL0NyaXRlcmlhQnVpbGRlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...om/solvd/movie/persistence/field/impl/Country.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvZmllbGQvaW1wbC9Db3VudHJ5LmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../com/solvd/movie/persistence/field/impl/Genre.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvZmllbGQvaW1wbC9HZW5yZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...m/solvd/movie/persistence/field/impl/Language.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvZmllbGQvaW1wbC9MYW5ndWFnZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...a/com/solvd/movie/persistence/field/impl/Name.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvZmllbGQvaW1wbC9OYW1lLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...om/solvd/movie/persistence/field/impl/Quality.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvZmllbGQvaW1wbC9RdWFsaXR5LmphdmE=) | `0.00% <0.00%> (ø)` | | | [...a/com/solvd/movie/persistence/field/impl/Year.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvZmllbGQvaW1wbC9ZZWFyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../persistence/impl/CriteriaMovieRepositoryImpl.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvcGVyc2lzdGVuY2UvaW1wbC9Dcml0ZXJpYU1vdmllUmVwb3NpdG9yeUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...m/solvd/movie/service/impl/EsMovieServiceImpl.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvc2VydmljZS9pbXBsL0VzTW92aWVTZXJ2aWNlSW1wbC5qYXZh) | `100.00% <100.00%> (+5.00%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/hizmailovich/movie-service/pull/36/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dukris commented 1 year ago

I have some problems with maven workflow, and I have no idea how to resolve it, because this test runs successfully

dukris commented 1 year ago

About junit-jupiter dependency I need it for annotations @Testcontainers and @Container

h1alexbel commented 1 year ago

About junit-jupiter dependency I need it for annotations @Testcontainers and @Container

@hizmailovich by the way it works without those annotations

so, what is the reason of usage such package?

dukris commented 1 year ago

I checked, yes, thanks, I can remove those annotations and container is really working, fixed

dukris commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@hizmailovich Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.