dukris / movie-service

Microservice for "Movie App"
1 stars 0 forks source link

GraphQL #42

Closed dukris closed 1 year ago

dukris commented 1 year ago

PR-Codex overview

This PR adds GraphQL functionality to the movie microservice, including new queries and mutations, a schema, and GraphQL error handling. It also updates dependencies and removes unused code.

Detailed summary

The following files were skipped due to too many changes: src/main/java/com/solvd/movie/web/controller/MovieController.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: +6.38 :tada:

Comparison is base (b4b12e9) 36.71% compared to head (62e9eff) 43.09%.

:exclamation: Current head 62e9eff differs from pull request most recent head 4ec1adc. Consider uploading reports for the commit 4ec1adc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #42 +/- ## ============================================ + Coverage 36.71% 43.09% +6.38% - Complexity 64 74 +10 ============================================ Files 37 37 Lines 286 297 +11 Branches 2 2 ============================================ + Hits 105 128 +23 + Misses 181 169 -12 ``` | [Impacted Files](https://app.codecov.io/gh/hizmailovich/movie-service/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich) | Coverage Δ | | |---|---|---| | [...vd/movie/web/controller/MovieControllerAdvice.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2NvbnRyb2xsZXIvTW92aWVDb250cm9sbGVyQWR2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../main/java/com/solvd/movie/model/fake/FkMovie.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvZmFrZS9Ga01vdmllLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...om/solvd/movie/web/controller/MovieController.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvd2ViL2NvbnRyb2xsZXIvTW92aWVDb250cm9sbGVyLmphdmE=) | `57.14% <100.00%> (+57.14%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/hizmailovich/movie-service/pull/42/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dukris commented 1 year ago

@h1alexbel Can I merge this pr?

dukris commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@hizmailovich Oops, I failed. You can see the full log here (spent 1min)

    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoFailureException: 

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
    at org.apache.maven.plugin.surefire.SurefireHelper.throwException (SurefireHelper.java:247)
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution (SurefireHelper.java:159)
    at org.apache.maven.plugin.failsafe.VerifyMojo.execute (VerifyMojo.java:190)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
\u001b[0m\u001b[0mcontainer 03f37cfd4087d42f0c7554f37f0eb6640e2198ef5c7f9f99eeab54ba51192c3d is dead
Tue 13 Jun 2023 03:42:32 PM CEST