dukris / movie-service

Microservice for "Movie App"
1 stars 0 forks source link

Test refactoring #45

Closed dukris closed 1 year ago

dukris commented 1 year ago

PR-Codex overview

This PR adds fake models and suppresses warnings for test classes. It also adds a JTCOP Maven plugin for code style checks.

Detailed summary

The following files were skipped due to too many changes: src/test/java/com/solvd/movie/persistence/EsMovieRepositoryIT.java, src/test/java/com/solvd/movie/service/impl/MovieServiceTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.92 :tada:

Comparison is base (7454d18) 43.09% compared to head (868032d) 44.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #45 +/- ## ============================================ + Coverage 43.09% 44.02% +0.92% - Complexity 74 75 +1 ============================================ Files 37 39 +2 Lines 297 318 +21 Branches 2 2 ============================================ + Hits 128 140 +12 - Misses 169 178 +9 ``` | [Impacted Files](https://app.codecov.io/gh/hizmailovich/movie-service/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich) | Coverage Δ | | |---|---|---| | [...a/com/solvd/movie/model/fake/FkSearchCriteria.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvZmFrZS9Ga1NlYXJjaENyaXRlcmlhLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...ain/java/com/solvd/movie/model/fake/FkEsMovie.java](https://app.codecov.io/gh/hizmailovich/movie-service/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hanna+Izmailovich#diff-c3JjL21haW4vamF2YS9jb20vc29sdmQvbW92aWUvbW9kZWwvZmFrZS9Ga0VzTW92aWUuamF2YQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dukris commented 1 year ago

@rultor merge

rultor commented 1 year ago

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 1 year ago

@rultor merge

@hizmailovich Done! FYI, the full log is here (took me 1min)