search

dulacp / Accountant

Accounting made accessible for small businesses and sole proprietorships through a simple Django project.
http://accountant-x.herokuapp.com/
MIT License
113 stars 56 forks source link

Force Python buildpack in app.json #1

Closed dzuelke closed 9 years ago

dzuelke commented 9 years ago

Deploy using the button fails otherwise - the package.json causes Heroku to detect the app as Node.js.

dzuelke commented 9 years ago

Also changes the Heroku button embed to use the better "implicit" template version, so that you can deploy branches and/or forks with it, too https://devcenter.heroku.com/articles/heroku-button#adding-the-heroku-button

Compare https://github.com/dzuelke/Accountant/tree/b9fe3221af36d8bb689ed1ba1f44d6fdcebb3310 (old, with the template URL hardcoded), which would not deploy my fork but the original, versus https://github.com/dzuelke/Accountant/tree/d68cf86815e3e947d15864801272536546962ce1 which correctly deploys my forked tree.

dulacp commented 9 years ago

Nice catch, thanks @dzuelke