"make install" can be more useful

GoogleCodeExporter commented 9 years ago

"make install" should install the processor's header files.

In conjunction with issue 218, "make install" should also install client
handler libraries, tool binaries, and relevant headers.

Original issue reported on code.google.com by mmento...@gmail.com on 28 Sep 2007 at 6:20

GoogleCodeExporter commented 9 years ago

Original comment by mmento...@gmail.com on 28 Sep 2007 at 6:20

Changed state: New

GoogleCodeExporter commented 9 years ago

This particular issue is making it very fiddly for me to use breakpad in our 
cross-platform app.

Original comment by mxcl@me.com on 10 Oct 2008 at 3:13

GoogleCodeExporter commented 9 years ago

We take patches. :)

Original comment by ted.mielczarek on 13 Oct 2008 at 2:00

GoogleCodeExporter commented 9 years ago

I was not quite sure which headers should be installed, but I specified 
exception_handler.h, google_crashdump_uploader.h and http_upload.h in this 
patch.

Additionally, I defined a new enviroment variable (INCLUDE_SRC_DIR) to match 
the platform-specific header directories (linux, mac, windows, solaris) as I 
was unable find something preexisting that could be used. I am not terribly 
familiar with autotools and there may be a more standardized way to do this.

Summary:
* $includedir default set to '${prefix}/include/google-breakpad'
* 'make install' should now include platform-specific headers

note: autoconf will need to be rerun after applying this patch

Original comment by nivar...@gmail.com on 22 May 2011 at 8:16

Attachments:

breakpad_install_includes.diff

GoogleCodeExporter commented 9 years ago

can someone please look to see if this patch is acceptable? it's annoying, as 
an end user of this library, to have to package it in our source tree. being 
able to install the breakpad headers will be extremely helpful.

Original comment by laviddic...@gmail.com on 14 Nov 2011 at 7:10

GoogleCodeExporter commented 9 years ago

The patch I posted is incomplete as it only included the headers I needed. It 
doesn't install the files in sub-directories, which is necessary to satisfy the 
header files own dependencies.

Original comment by nivar...@gmail.com on 14 Nov 2011 at 8:35

GoogleCodeExporter commented 9 years ago

Agreed, this is not acceptable of library to not have an option to install it's 
header files.

Original comment by bjoerk.e...@gmail.com on 20 Apr 2012 at 1:47

GoogleCodeExporter commented 9 years ago

Yes, it would be really good for make install to install headers. I'm trying to 
add this library to gentoo sunrise overlay now and here are patches I use for 
installing headers. This patch adds rules for headers and also installs the .pc 
file. Could it be added to the upstream version?

Original comment by piatli...@gmail.com on 16 Aug 2012 at 8:19

Attachments:

GoogleCodeExporter commented 9 years ago

This patch is only for linux, so should be changed appropriately for supporting 
of other platforms.

Original comment by piatli...@gmail.com on 16 Aug 2012 at 8:21

GoogleCodeExporter commented 9 years ago

.pc files should never be patched in downstream, so please fix this. Otherwise 
it does not make much sense to include google-breakpad in distributions.

Original comment by julian.o...@googlemail.com on 17 Aug 2012 at 8:13

GoogleCodeExporter commented 9 years ago

#8 Your patch doesn't seem to work for out-of-source builds. I get:
    make: *** No rule to make target `src/common/*.h', needed by `all-am'.  Stop.

Original comment by nshutchi...@gmail.com on 26 Nov 2012 at 6:06

GoogleCodeExporter commented 9 years ago

It may be. I have not tested it for out-of-source builds. I'll try to look at 
this problem in a few weeks.

Original comment by piatli...@gmail.com on 29 Nov 2012 at 12:30

GoogleCodeExporter commented 9 years ago

Based on the above, an updated patch to install headers and .pc files

- Tested with in and out of tree source builds
- Installs breakpad.pc if libbreakpad is installed
- Installs breakpad-client.pc if libbreakpad_client is installed
- Installs linux-specific headers only on linux :-)

Original comment by b152fee4...@gmail.com on 27 Jan 2014 at 10:53

Attachments:

install-headers.patch

GoogleCodeExporter commented 9 years ago

Jon: Please see 
https://code.google.com/p/google-breakpad/wiki/ContributingToBreakpad and the 
Breakpad README file for how to get submit patches.

Original comment by thestig@chromium.org on 27 Jan 2014 at 11:01

GoogleCodeExporter commented 9 years ago

I have signed the CLA.
Patch uploaded at https://breakpad.appspot.com/1114002/

Original comment by b152fee4...@gmail.com on 28 Jan 2014 at 5:15

GoogleCodeExporter commented 9 years ago

Ping?

> Jon: Please see ... the Breakpad README file for how to get submit patches.

Step 0 in the README says "get write access" :)

Original comment by b152fee4...@gmail.com on 10 Mar 2014 at 1:37

GoogleCodeExporter commented 9 years ago

Is there any progress on this? I would really like to see this work!

Original comment by l...@foldspace.nu on 30 May 2014 at 8:12

GoogleCodeExporter commented 9 years ago

Is jon from #15 still taking care of it or shall I repost his patch, following 
the steps in README?

Original comment by pascal.h...@gmail.com on 30 Jul 2014 at 2:30

GoogleCodeExporter commented 9 years ago

Is Jon still waiting for write access? Or has he given up?
We've got a patch! Can we get some movement on getting it accepted?!

Original comment by l...@foldspace.nu on 5 Aug 2014 at 6:23

GoogleCodeExporter commented 9 years ago

Committed as svn r1364

Original comment by b152fee4...@gmail.com on 29 Aug 2014 at 12:20

duliangang / google-breakpad

"make install" can be more useful #219