dulimarta / spherical-easel

https://spherical-easel.vercel.app
Other
3 stars 7 forks source link

Incorrect tangents/normals to parametric curves after sphere rotation #57

Closed dulimarta closed 2 years ago

dulimarta commented 2 years ago

Tangents/Normals are computed correctly when a parametric is in its neutral pose but seem to be off when the sphere is rotated.

Potential issue: RotationVisitor::actionOnParametric updates only the coordinates of the parametric sample points but it does not update the first and second derivatives.

dulimarta commented 2 years ago

Fixed in 4c849b37bb1607af9e59e2f468477bffc53b7f97