Open shengjunlin opened 2 years ago
Dear Sheng-Jun Lin,
thanks for pointing this out. This is a Python package that I did not write, so it is hard for me to judge what the author meant with this. But it does seem you are right. I'll keep this issue open and see if someone else (who uses radmc3dPy with the convolution) confirms your suggestion. Then I'll build it in the way you suggest.
Best wishes, Kees
Dear Kees,
Thank you for your reply!
Best wishes, Sheng-Jun
Incidentally, I agree with Sheng-Jun Lin's proposed fix.
In lines 373 ~ 376 at radmc3dPy/image.py,
radmc3dImage.writeFits()
has a wrong unit conversion for images which has been convolved byradmc3dImage.imConv()
.In the convolved
radmc3dImage
object returned byimConv()
, itsself.image
still has the unit of erg/s/cm/cm/ster. In fact, this design is consistent with the behavior ofimage.plotImage(bunit='jy/beam')
, which correctly first convert the values inself.image
from erg/s/cm/cm/ster to Jy/pixel, and then convert it to Jy/beam in lines 1466 ~1487. This bug inradmc3dImage.writeFits()
could be fixed by changing things to