dumbeau / AutoHotPie

Radial menus in Windows, aka PIE MENYOOS!
MIT License
340 stars 18 forks source link

Pie Enable Key doesn't work and some feature requests #9

Closed rexelbartolome closed 2 years ago

rexelbartolome commented 2 years ago

Both the toggle and hold version for enabling the Pie Menu don't work, also would like some sort of pop up or notification what state a Pie Menu is on when the Enable Pie Key is pressed if that's alright :D

Also thought of a bunch of UX things

When adding a Function to a Slice, after clicking Send Key on the dropdown, you can make it go straight to the Press a Key screen, instead of having to click Assign Key button before the Press a Key comes up. Same goes for the Run File function.

When adding a new pie menu, clicking Add Pie Menu button doesn't notify you if you haven't assigned a Keystroke for the pie menu yet. So I thought it just didn't work for some reason 😅

dumbeau commented 2 years ago

Both the toggle and hold version for enabling the Pie Menu don't work, also would like some sort of pop up or notification what state a Pie Menu is on when the Enable Pie Key is pressed if that's alright :D

Ope, yikes yeah I'll fix that. As for the overlay notification, that's a good idea. I would want to make this very small overlay in the bottom right of the screen the mouse is on and only use it for if the Pie Enable Key is set to toggle. Off the top of my head maybe something like this? Open to ideas here, looking for something unobtrusive. image

I feel like the overlay would get annoying if somebody is using the 'Hold' mode. Do you think it would be necessary for the Hold mode? Seems like it might be helpful to see at first but could get annoying later, and just having the key pressed is enough.

When adding a Function to a Slice, after clicking Send Key on the dropdown, you can make it go straight to the Press a Key screen, instead of having to click Assign Key button before the Press a Key comes up. Same goes for the Run File function.

This will be added for 'Send Key', 'Run File' and 'Open Folder'.

When adding a new pie menu, clicking Add Pie Menu button doesn't notify you if you haven't assigned a Keystroke for the pie menu yet. So I thought it just didn't work for some reason 😅

I considered doing this, and then I decided I'll come back to it and just forgot about it. There are a few places I need to add data validation warnings. Not even difficult to do, I just got lazy on that one 😅. Thanks again for finding my bugs and for the good suggestions!

dumbeau commented 2 years ago

'Pie Enable Key' is partially fixed in v1.0.8 at the moment.

There is an issue with Pie Menus locking up and blocking LButton when aggressively tapping the pie enable key with pie menu hotkeys that have Ctrl or Alt as a modifier (Shift and keys without other modifiers seem fine). You have to Ctrl+Shift+Esc for task manager and force close PieMenu.exe if it ever happens. But I won't be able to work on this again until later this week so I just wanted to get the pie enable keys functional quick.

rexelbartolome commented 2 years ago

Great! And yea it's alright, I don't use the Pie Enable feature very often so I'm fine with waiting.

Off the top of my head maybe something like this? Open to ideas here, looking for something unobtrusive. Yeah I think that's great. And I'm assuming the Pie Menus will be replaced by the Pie Menu name? Or is that for a global enable/disable?

I don't think it needs to be seen on Hold mode, as I think Hold mode kind of caters more to advanced/super users compared to Toggle anyway.

And you're welcome! 😊

rexelbartolome commented 2 years ago

There is an issue with Pie Menus locking up and blocking LButton when aggressively tapping the pie enable key with pie menu hotkeys that have Ctrl or Alt as a modifier (Shift and keys without other modifiers seem fine).

For some reason this issue also happens when you use explorer.exe as an assigned program for one of the profiles. I have the pie enable key assigned to 0 with no modifier keys and when I run it, it becomes blocked when I try to open the profile's pie menu. It still happens even if the pie enable key is turned off for it. It would only work if I disable the profile entirely.

Also I found out that right click is still usable when blocked, and when you right click autohotpie on the system tray, you get to left click one of the options. So no opening of task manager necessary :D

dumbeau commented 2 years ago

Nice, I did put up some updates that I think fixed the locking up issue (updated build of 1.0.8), so feel free to give it a try. explorer.exe is kind of a special case application when it comes to sensing it. I'll look into that though, because I'm sure that's going to be a common desired profile.

dumbeau commented 2 years ago

All of these feature requests have been added and LMB locking has been fixed in v1.0.10.

As always, feel free to give feedback on these changes or reopen if you find a problem.