Fix - true values from resources were evaluated as booleans - Githubissues

dumindarw / kafka-oauthbearer-keycloak

SASL/OAUTHBEARER mechanism with Keycloak

2 stars 6 forks source link

Fix - true values from resources were evaluated as booleans #1

Open mbcsa opened 2 years ago

mbcsa commented 2 years ago

Function getPropertyValueByKey returns String values, but some configurations are evaluated as booleans

getPropertyValueByKey("OAUTH_WITH_SSL").equals(true)
getPropertyValueByKey("OAUTH_ACCEPT_UNSECURE_SERVER").equals(true)

In the first case result is false and makes http requests to be sent as HTTP instead of HTTPS.

When respectively changed to

getPropertyValueByKey("OAUTH_WITH_SSL").equals("true")
getPropertyValueByKey("OAUTH_ACCEPT_UNSECURE_SERVER").equals("true")

works as expected.