dump247 / storybook-state

Manage component state in React storybook.
MIT License
76 stars 17 forks source link

breaks on Storybook 5.0 #16

Closed dannystyleart closed 5 years ago

dannystyleart commented 5 years ago

Current Storybook version: 5.0.1 Curent storybook-state version: 1.5.2

Issues:

After upgrading to storybook 5 there are several issues.

react-keys-error StatePanel does not apply key prop in children and therefore a react-keys error thrown:

vendors~main.dece1ba2959ef3cd23e2.bundle.js:130734 Warning: Each child in a list should have a unique "key" prop.

Check the top-level render call using <Styled(div)>. See https://fb.me/react-warning-keys for more information.
    in StatePanel
    in Unknown
    in Unknown
    in Unknown
    in Unknown (created by Context.Consumer)
    in _default (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Panel)
    in Panel (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

performance Issue When state contains a larger value object, like a simple google place query, the story becomes very laggy.

dump247 commented 5 years ago

Should be resolved in v1.6.0