search

dumptyd / vue-css-donut-chart

Lightweight Vue component for drawing pure CSS donut charts
https://dumptyd.github.io/vue-css-donut-chart/
MIT License
128 stars 19 forks source link

Minor hygiene fixes #20

Closed cjblomqvist closed 4 years ago

cjblomqvist commented 4 years ago

See commits. Minor fixes to make it easier for other developers to contribute to the project.

dumptyd commented 4 years ago

Those commands don't require the user to have vue-cli-service globally installed. https://docs.npmjs.com/misc/scripts#path

cjblomqvist commented 4 years ago

Hmm, that's weird - because it didn't work for me (I didn't get any .bin folder at all and when I ran the commands I got errors telling me vue-cli-service wasn't a known executable).

I'm on windows with npm 6.1.

dumptyd commented 4 years ago

That's indeed very weird. But I'm afraid that's not related to this project. Maybe file a bug on vue-cli? They might be able to help you. I'm closing this for now but thank you for showing interest in contributing to the project.

One of these days I will write a contributing guide. :sweat_smile: