dumptyd / vue-css-donut-chart

Lightweight Vue component for drawing pure CSS donut charts
https://dumptyd.github.io/vue-css-donut-chart/
MIT License
128 stars 19 forks source link

Turn off fontsize calculation #21

Closed cjblomqvist closed 4 years ago

cjblomqvist commented 4 years ago

See #20 which is part of this PR as well.

Adds support for turning of automatic font-size calculations (and turning of setting font-size at all). It's currently not easily possible to override the font-size and set it to something fixed - this is now possible by turning off the automatic font-size calculations.

detaybey commented 4 years ago

waiting for this fix <3

detaybey commented 4 years ago

stuck with README.md conflict.... :/

dumptyd commented 4 years ago

There are a few reasons I didn't go with this PR.

Now, I don't expect anyone to know these things as they start working on this repo because I haven't created a contributing guide yet. I will create one soon when I get time though.

Again, thanks a lot for showing interest in contributing to the repo, I really appreciate it. But for now, I'm closing this PR as I've created a new one with different implementation - #30. You can check out the diff there to see how it's being implemented and what things are updated.


@detaybey You can track this in #30 as well. 🙂

dumptyd commented 4 years ago

This has been implemented in 1.3.0.

cjblomqvist commented 4 years ago

Fair enough - thanks for your effort @dumptyd !