Closed dumptyd closed 4 years ago
Merging #26 into 1.2.0 will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## 1.2.0 #26 +/- ##
====================================
Coverage 100% 100%
====================================
Files 4 5 +1
Lines 104 140 +36
Branches 23 31 +8
====================================
+ Hits 104 140 +36
Impacted Files | Coverage Δ | |
---|---|---|
src/components/Donut.vue | 100% <100%> (ø) |
:arrow_up: |
src/utils/events.js | 100% <100%> (ø) |
|
src/components/DonutSections.vue | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f045bfc...b9c977d. Read the comment docs.
This PR implements the following changes:
Library
section-mouseenter
section-mouseleave
section-mouseover
section-mouseout
section-mousemove
section-*
events are now emitted with the native event object as the second parameter.Documentation
Demo
for
attribute mapped toid
.Implementation
Implementation wise, this PR makes it very easy to add support for new native section events. The process would be as simple as updating the
utils/events.js
file with the event name and the event would be supported on the section. An entry for the event would be made on the demo page as well. The coverage wouldn't drop either because tests are generated dynamically for these events. Of course the README would have to be updated too.