dumpus-app / dumpus-landing

Simple static website for details, screenshots, etc. about the Dumpus app
https://dumpus.app
2 stars 1 forks source link

feat: rewrite with vuejs #5

Closed Mittelblut9 closed 1 year ago

Mittelblut9 commented 1 year ago

Should work everything.

It's explained how to install and run the dev server in the readme.

May add some prettier workflows in future pr's

Closes #3

Androz2091 commented 1 year ago

It seems incredible! Thank you for your work, I will review it probably before Aug 9th

Androz2091 commented 1 year ago

@florian-lefebvre can you have a look when you have some time?

Mittelblut9 commented 1 year ago
Mittelblut9 commented 1 year ago

@florian-lefebvre

I don't really know typescript

florian-lefebvre commented 1 year ago

No worries, nothing complicated in our case, it won't annoy you while developing

florian-lefebvre commented 1 year ago

I'll make the changes I noted above, you'll just have to pull that's all

florian-lefebvre commented 1 year ago

I haven't touched styles, I think it will need to be migrated later to tailwindcss to be maintainable

Mittelblut9 commented 1 year ago

Any new updates on this pr? Ig my part is done. If you wan't to migrate to tailwindcss, go ahead. Haven't touched this yet. 😅 If you have some bugs or style issues lemme know 👍

Androz2091 commented 1 year ago

Screenshot from 2023-08-15 08-17-41 @Mittelblut9 thank you for the changes I still have this issue, do you know why?

florian-lefebvre commented 1 year ago

I think it has something with some some styles not being scoped on the home page.

Maybe here? https://github.com/Mittelblut9/dumpus-landing/blob/main/src/views/Homepage.vue#L159

florian-lefebvre commented 1 year ago

Tried adding scoped but it breaks everything 🤔. Let's just merge like this and refactor in another pr to tailwind