Closed Mittelblut9 closed 1 year ago
It seems incredible! Thank you for your work, I will review it probably before Aug 9th
@florian-lefebvre can you have a look when you have some time?
@florian-lefebvre
I don't really know typescript
No worries, nothing complicated in our case, it won't annoy you while developing
I'll make the changes I noted above, you'll just have to pull that's all
I haven't touched styles, I think it will need to be migrated later to tailwindcss to be maintainable
Any new updates on this pr? Ig my part is done. If you wan't to migrate to tailwindcss, go ahead. Haven't touched this yet. 😅 If you have some bugs or style issues lemme know 👍
@Mittelblut9 thank you for the changes I still have this issue, do you know why?
I think it has something with some some styles not being scoped on the home page.
Maybe here? https://github.com/Mittelblut9/dumpus-landing/blob/main/src/views/Homepage.vue#L159
Tried adding scoped
but it breaks everything 🤔. Let's just merge like this and refactor in another pr to tailwind
Should work everything.
It's explained how to install and run the dev server in the readme.
May add some prettier workflows in future pr's
Closes #3